Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startExpanded=True expands all nodes by default #56

Closed
wants to merge 3 commits into from

Conversation

saetsac
Copy link

@saetsac saetsac commented Apr 10, 2017

Change startExpanded behavior so we could expand all child nodes automatically

Description

Inherits startExpanded from parent element. Tracks element by $index (without it arrays were failing to expand)

Motivation and Context

startExpanded by expanding only the top element is kind of a strange thing. We need to expand everything at once.

How Has This Been Tested?

Unittests 4/4 pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the test suite.
  • I have written a test to cover the change.

@vinnyb0341
Copy link

is there any chance this pull request will be merged?

@awendland
Copy link
Owner

Apologies for the massive delays in reviewing these PRs, I will attempt to review this on the weekend. Thank you for the addition to the project!

@vinnyb0341
Copy link

Don't mean to keep nagging on this, but is this getting reviewed soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants