Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Issue// precompiling-with-webpack // Test against precompiled sources #1614

Closed
LyzioOh opened this issue Dec 14, 2017 · 3 comments
Closed
Labels
bug current functionality does not work as desired good for beginner help wanted scope:documentation

Comments

@LyzioOh
Copy link

LyzioOh commented Dec 14, 2017

Doc Issue
In Precompiling-with-webpack // Test against precompiled sources, the last webpack configuration file is presented as being webpack.config.js, but it's seem it's fact it's the webpack.config.test.js.
Or does i misunderstood something ?

https://github.com/avajs/ava/blob/master/docs/recipes/precompiling-with-webpack.md#webpackconfigjs-3

@novemberborn novemberborn added bug current functionality does not work as desired good for beginner help wanted scope:documentation labels Dec 28, 2017
@novemberborn
Copy link
Member

@EEtancelin I think you're right, the precompile-tests line should be updated to load webpack.config.js. Would you like to do a PR to make that change?

@ppatel221
Copy link
Contributor

Hello, Im a student in an Open-Source development class and looking to contribute. Can i take care of this?

@ppatel221
Copy link
Contributor

Ive requested a PR #1625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug current functionality does not work as desired good for beginner help wanted scope:documentation
Projects
None yet
Development

No branches or pull requests

3 participants