Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatValue() reference #1323

Merged
merged 1 commit into from
Mar 25, 2017
Merged

Fix formatValue() reference #1323

merged 1 commit into from
Mar 25, 2017

Conversation

novemberborn
Copy link
Member

Fixes #1321.

Turns out we don't have any real integration tests for assertion enhancement. I don't have time to add those right now either, but at least this fixes master.

With the sample code from #1321:

❯ "$(npm bin)"/ava test.js

  1 failed

  [anonymous]
  /private/var/folders/_6/p8qxp_3n62zg9081tvb0lcc80000gn/T/tmp.okeY2IXLOl/test.js:5

   4:   const x = () => 'foo';
   5:   t.regex(x(), /\d/);
   6: });

  Value must match expression:

    "foo"

  Regular expression:

    /\d/

  x()
  => "foo"

@sindresorhus sindresorhus merged commit 2a20631 into master Mar 25, 2017
@sindresorhus sindresorhus deleted the fix-enhanced-formatting branch March 25, 2017 16:56
@sindresorhus
Copy link
Member

👍

I've opened an issue about better integration tests: #1324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert formatter throws on t.regex not matching
2 participants