diff --git a/src/Jaeger/Jaeger.php b/src/Jaeger/Jaeger.php index da52b01..85a0942 100644 --- a/src/Jaeger/Jaeger.php +++ b/src/Jaeger/Jaeger.php @@ -270,7 +270,7 @@ public function gen128bit(): void public function flush(): void { $this->reportSpan(); - $this->reporter->close(); + $this->reporter->flush(); } private function generateId(): string diff --git a/src/Jaeger/Reporter/NullReporter.php b/src/Jaeger/Reporter/NullReporter.php index ee50900..65a5c3c 100644 --- a/src/Jaeger/Reporter/NullReporter.php +++ b/src/Jaeger/Reporter/NullReporter.php @@ -24,6 +24,11 @@ public function report(Jaeger $jaeger) // no-op } + public function flush() + { + // no-op + } + public function close() { // no-op diff --git a/src/Jaeger/Reporter/RemoteReporter.php b/src/Jaeger/Reporter/RemoteReporter.php index 0cec81f..84ca421 100644 --- a/src/Jaeger/Reporter/RemoteReporter.php +++ b/src/Jaeger/Reporter/RemoteReporter.php @@ -35,6 +35,11 @@ public function report(Jaeger $jaeger) $this->tran->append($jaeger); } + public function flush() + { + $this->tran->flush(); + } + public function close() { $this->tran->close(); diff --git a/src/Jaeger/Reporter/Reporter.php b/src/Jaeger/Reporter/Reporter.php index 4e7f6bd..aa1304a 100644 --- a/src/Jaeger/Reporter/Reporter.php +++ b/src/Jaeger/Reporter/Reporter.php @@ -21,5 +21,7 @@ interface Reporter { public function report(Jaeger $jaeger); + public function flush(); + public function close(); } diff --git a/src/Jaeger/SpanContext.php b/src/Jaeger/SpanContext.php index 08be732..1c10d4d 100644 --- a/src/Jaeger/SpanContext.php +++ b/src/Jaeger/SpanContext.php @@ -71,6 +71,8 @@ public function withBaggageItem(string $key, string $value): \OpenTracing\SpanCo /** * {@inheritdoc} + * + * @return \Traversable */ public function getIterator() {