Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to choose sampling strategy #4

Closed
cawolf opened this issue Jan 8, 2020 · 2 comments
Closed

add possibility to choose sampling strategy #4

cawolf opened this issue Jan 8, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cawolf
Copy link
Member

cawolf commented Jan 8, 2020

Despite having no consensus on a specification for sampling in general, most tracers are actually providing two basic tracer types:

  • constant samplers (always tracing, never tracing)
  • probabilistic samplers

Right now, we are enabling the constant samplers (always tracing) by default for tracing implementations. However, as high-traffic projects are going to use this bundle, there will be the need of choosing other strategies (probably at configure-time, maybe even at runtime).

In order to provide this feature to bundle users, we should research how current tracer implementations are handling and passing these configurations and maybe come up with an abstraction.

@cawolf cawolf added the enhancement New feature or request label Jan 8, 2020
@cawolf
Copy link
Member Author

cawolf commented Mar 9, 2020

Upon further discussion with @mmross we came to the conclusion, that right now we want to configure the sampling behaviour individually per tracer implementation. Coincidently, both Jaeger and Zipkin provide implementations for Const and Probabilistic sampling, but this is currently not enough for a general abstraction. We will, however, name both vendor configurations identically, so that a future abstraction can be done smoothly.

@cawolf
Copy link
Member Author

cawolf commented Mar 19, 2020

All PRs are merged, closing

@cawolf cawolf closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants