You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
jcchavezs/zipkin-opentracing had an incorrect return type-hint which leads to a TypeError rendering this bundle unusable. This was resolved in jcchavezs/zipkin-php-opentracing#49. They pushed a version 1.0.0 which has the fix in place. However this version uses opentracing/opentracing 1.0.1 with which your bundle is incompatible because of how dependencies are handled.
@cawolf mentioned in auxmoney/OpentracingBundle-core#53 that jukylin/jaeger-php#95 is a blocker for this. However this project has not released since May 28, 2020 despite them even having a pending PR for it. Would you consider leaving the JaegerBundle as is until they sort it out and update core and other bundles to opentracing 1.0?
The text was updated successfully, but these errors were encountered:
thank you for raising this issue. We understand the problem and were thinking about forking the original vendor for some time now, for the exact same reason you mentioned. Your issue is now the reason to actually do so.
Our reasoning for this step is, that if we would drop the jaeger-php vendor, we would lose all our functional tests for most of our plugins, and we are not very happy to do so. Instead, we will be fixing and finalizing the dev_v3 branch, which is nearly complete, and release it soon as auxmoney/jaeger-php. We will then migrate our functional tests in all plugins and the auxmoney/OpentracingBundle-Jaeger plugin itself to our vendor, updating to opentracing 1.0.1 in the process.
jcchavezs/zipkin-opentracing
had an incorrect return type-hint which leads to a TypeError rendering this bundle unusable. This was resolved in jcchavezs/zipkin-php-opentracing#49. They pushed a version 1.0.0 which has the fix in place. However this version usesopentracing/opentracing
1.0.1 with which your bundle is incompatible because of how dependencies are handled.@cawolf mentioned in auxmoney/OpentracingBundle-core#53 that jukylin/jaeger-php#95 is a blocker for this. However this project has not released since May 28, 2020 despite them even having a pending PR for it. Would you consider leaving the JaegerBundle as is until they sort it out and update core and other bundles to opentracing 1.0?
The text was updated successfully, but these errors were encountered: