Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return type-hint in jcchavezs/zipkin-opentracing 0.2 #21

Closed
Rainrider opened this issue Sep 29, 2021 · 2 comments · Fixed by #23
Closed

Incorrect return type-hint in jcchavezs/zipkin-opentracing 0.2 #21

Rainrider opened this issue Sep 29, 2021 · 2 comments · Fixed by #23
Labels
bug Something isn't working released

Comments

@Rainrider
Copy link

jcchavezs/zipkin-opentracing had an incorrect return type-hint which leads to a TypeError rendering this bundle unusable. This was resolved in jcchavezs/zipkin-php-opentracing#49. They pushed a version 1.0.0 which has the fix in place. However this version uses opentracing/opentracing 1.0.1 with which your bundle is incompatible because of how dependencies are handled.

@cawolf mentioned in auxmoney/OpentracingBundle-core#53 that jukylin/jaeger-php#95 is a blocker for this. However this project has not released since May 28, 2020 despite them even having a pending PR for it. Would you consider leaving the JaegerBundle as is until they sort it out and update core and other bundles to opentracing 1.0?

@cawolf
Copy link
Member

cawolf commented Oct 5, 2021

Hi @Rainrider ,

thank you for raising this issue. We understand the problem and were thinking about forking the original vendor for some time now, for the exact same reason you mentioned. Your issue is now the reason to actually do so.

Our reasoning for this step is, that if we would drop the jaeger-php vendor, we would lose all our functional tests for most of our plugins, and we are not very happy to do so. Instead, we will be fixing and finalizing the dev_v3 branch, which is nearly complete, and release it soon as auxmoney/jaeger-php. We will then migrate our functional tests in all plugins and the auxmoney/OpentracingBundle-Jaeger plugin itself to our vendor, updating to opentracing 1.0.1 in the process.

@cawolf cawolf added the bug Something isn't working label Oct 5, 2021
@cawolf
Copy link
Member

cawolf commented Nov 16, 2021

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
2 participants