Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to include more extrinsic into bundle before quitting #2386

Closed
NingLin-P opened this issue Jan 4, 2024 · 1 comment
Closed

Try to include more extrinsic into bundle before quitting #2386

NingLin-P opened this issue Jan 4, 2024 · 1 comment
Assignees
@NingLin-P
Labels
execution Subspace execution improvement it is already working, but can be better

Comments

@NingLin-P
Copy link
Member

Currently, the operator will stop immediately including more extrinsic into its bundle once a particular extrinsic can't fit into the bundle:
https://github.com/subspace/subspace/blob/21fd58be039be4a5c5f33592e63749ec68a99a16/domains/client/domain-operator/src/domain_bundle_proposer.rs#L142-L151

But the bundle may not be full yet if that particular extrinsic has a large size/weight. Ideally, similar to how the substrate block builder works, the operator should try a few more times for other extrinsic in the pool to maximize bundle utilization.
@NingLin-P NingLin-P added improvement it is already working, but can be better execution Subspace execution labels Jan 4, 2024
@NingLin-P NingLin-P self-assigned this Jan 18, 2024
@NingLin-P
Copy link
Member Author

Close as #2454 implemented this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NingLin-P NingLin-P

Labels
execution Subspace execution improvement it is already working, but can be better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NingLin-P