Fix saveUnknown throwing errors when value where falsy #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a model has saveUnknown=true and trying to save the model with an unknown attribute with
0
orfalse
values was causingAttribute.setTypeFromRawValue
to throw aSchemaError
.I remove the value check from
setTypeFromRawValue
, which I assume was unnecessarily copied fromsetType
. This allows0
andfalse
to be correctly converted to dynamo types.Attributes with the other falsy values like are
null
,undefined
, or 'NaN' are now excluded because it was causingnew Attribute
to throwTypeError
at https://github.com/automategreen/dynamoose/blob/35deac2aaaa418f01b37d9bf8427626a22d142d7/lib/Attribute.js#L12Also fix the NewModel name test to include missing suffix.