Feature/add enum attribute #274
Conversation
1 similar comment
docs/_docs/schema.md
Outdated
| @@ -122,6 +126,10 @@ function(model) { | |||
| } | |||
| ``` | |||
|
|
|||
| **Enum: Array of string** | |||
There was a problem hiding this comment.
This should probably be enum not Enum, correct? And probably array of strings.
There was a problem hiding this comment.
Fixed this in my commit to this PR
| oscar.save(function(err) { | ||
| should(err).be.null(); | ||
|
|
||
| Dog.$__.table.delete(function () { |
There was a problem hiding this comment.
What's the reason for the table.delete here?
There was a problem hiding this comment.
After looking at this closer this now makes sense.
| @@ -427,6 +427,11 @@ Attribute.prototype.toDynamo = function(val, noSet, model) { | |||
| } | |||
|
|
|||
| if(type.dynamo === 'S') { | |||
| if (this.options.enum) { | |||
There was a problem hiding this comment.
This looks to be in the toDynamo function. Do we think it would be beneficial to add it to the fromDynamo function as well? Not sure if it makes sense, what are your thoughts on this?
There was a problem hiding this comment.
@brandongoode can you take a look at this and let me know your thoughts? Do you think we should add this to fromDynamo as well? Should we throw an error in the fromDynamo if it's not correct in the enum, or?
Add enum feature like mongoose one with tests and documentation.
Don't hesitate to tell me if there is something to change or if something is missing.
Fixes #239