feat(UI-1313): add tooltip to sidebar menu items #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonenMars
reviewed
Feb 11, 2025
src/components/atoms/tooltip.tsx
Outdated
| @@ -5,20 +5,20 @@ import { FloatingPortal, offset, useFloating, useHover, useInteractions, shift } | |||
| import { TooltipProps } from "@src/interfaces/components"; | |||
| import { cn } from "@src/utilities"; | |||
|
|
|||
| export const Tooltip = ({ content, children, variant = "default" }: TooltipProps) => { | |||
| export const Tooltip = ({ content, children, variant = "default", position = "top", disabled }: TooltipProps) => { | |||
There was a problem hiding this comment.
Suggested change
| export const Tooltip = ({ content, children, variant = "default", position = "top", disabled }: TooltipProps) => { | |
| export const Tooltip = ({ content, children, variant = "default", position = "top", hide }: TooltipProps) => { |
src/components/atoms/tooltip.tsx
Outdated
Comment on lines
39
to
40
| className={cn("z-40 rounded-md px-3 py-2 text-sm shadow-md", { | ||
| "bg-gray-850 text-white": variant === "default", |
There was a problem hiding this comment.
Where variant === error have gone? 🤔
Also, what do you think if we'll extract the styles into a constant?
const tooltipStyles = {
default: "bg-gray-850 text-white",
error: "bg-red-600 text-white",
};
There was a problem hiding this comment.
good idea, refactored
RonenMars
approved these changes
Feb 11, 2025
RonenMars
force-pushed
the
vitaly/feat/tooltip-sidebar-menu-items
branch
from
6b7e449 to
21f1e02
Compare
|
🎉 This PR is included in version 2.141.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tooltip to sidebar menu
Linear Ticket
https://linear.app/autokitteh/issue/UI-1313/menu-hover-with-name-tootlip
What type of PR is this? (check all applicable)