Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI-1300): add required fields for entry function and file path in trigger form #976

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

J1za
Copy link
Collaborator

@J1za J1za commented Feb 10, 2025

Description

The user shouldn't be able to save a trigger without file and function.

Check on all trigger types: connection, scheduler, webhook

Linear Ticket

https://linear.app/autokitteh/issue/UI-1300/disable-trigger-save-without-file-and-function

What type of PR is this? (check all applicable)

  • 💡 (feat) - A new feature (non-breaking change which adds functionality)
  • 🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
  • 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
  • 🏎 (perf) - Optimization
  • 📄 (docs) - Documentation - Documentation only changes
  • 📄 (test) - Tests - Adding missing tests or correcting existing tests
  • 🎨 (style) - Styles - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • ⚙️ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • ☑️ (chore) - Chores - Other changes that don't modify src or test files
  • ↩️ (revert) - Reverts - Reverts a previous commit(s).

@RonenMars RonenMars self-requested a review February 11, 2025 07:49
@RonenMars RonenMars enabled auto-merge (squash) February 11, 2025 08:26
@RonenMars RonenMars force-pushed the vitaly/fix/revalidation-trigger-form branch from f0f48e3 to d8a7283 Compare February 11, 2025 08:26
@RonenMars RonenMars force-pushed the vitaly/fix/revalidation-trigger-form branch from d8a7283 to 0db66cf Compare February 11, 2025 08:44
@RonenMars RonenMars merged commit b09e1a2 into main Feb 11, 2025
31 of 34 checks passed
@RonenMars RonenMars deleted the vitaly/fix/revalidation-trigger-form branch February 11, 2025 08:49
Copy link

🎉 This PR is included in version 2.140.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants