Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Relay error handling #212

Closed
louischan-oursky opened this issue Aug 28, 2020 · 0 comments · Fixed by #213
Closed

Fix Relay error handling #212

louischan-oursky opened this issue Aug 28, 2020 · 0 comments · Fixed by #213
Assignees
@louischan-oursky

Comments

@louischan-oursky
Copy link
Collaborator

The graphql spec allows both data and errors to present in the response. But relay does not handle it well, so we have to update our fetch function to discard data is errors is present.
@louischan-oursky louischan-oursky self-assigned this Aug 28, 2020
louischan-oursky added a commit to louischan-oursky/authgear-server that referenced this issue Aug 28, 2020
@louischan-oursky
Fix Relay error handling
dd90c13 
ref authgear#212
@louischan-oursky louischan-oursky mentioned this issue Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Relay error handling louischan-oursky/authgear-server
1 participant
@louischan-oursky