Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No 'id' attribute on password input or login button #2067

Closed
shaneagibson opened this issue Nov 25, 2021 · 1 comment · Fixed by #2072
Closed

No 'id' attribute on password input or login button #2067

shaneagibson opened this issue Nov 25, 2021 · 1 comment · Fixed by #2072
Labels
bug report This issue reports a suspect bug or issue with the SDK itself

Comments

@shaneagibson
Copy link

shaneagibson commented Nov 25, 2021

Describe the problem

The Password input and Login button do not contain id attributes.

This attribute was previously added to the Email input in v11.12.0. It would be valuable to have the same added to the Password input and Login button.

Without this, SaaS cookie consent tooling such as OneTrust are unable to perform a login as they rely solely on the ID attribute.

What was the expected behavior?

The password input should contain something like:

id="{lockId}-password"

The login button should contain something like:

id="{lockId}-submit"

Reproduction

  1. Render the login page
  2. View the DOM
  3. Inspect the password input and login button elements

Environment

  • Version of this library used: 11.31.1
  • Which framework are you using, if applicable: N/A
  • Other modules/plugins/libraries that might be involved: N/A
  • Any other relevant information you think would be useful: N/A
@shaneagibson shaneagibson added the bug report This issue reports a suspect bug or issue with the SDK itself label Nov 25, 2021
@shaneagibson shaneagibson changed the title No 'id' attribute on password input No 'id' attribute on password input or login button Nov 25, 2021
@stevehobbsdev
Copy link
Contributor

Thanks for your patience here @shaneagibson , I've raised #2072 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report This issue reports a suspect bug or issue with the SDK itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants