Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No token type #136

Closed
zalito12 opened this issue Jan 20, 2017 · 1 comment
Closed

No token type #136

zalito12 opened this issue Jan 20, 2017 · 1 comment
Milestone

Comments

@zalito12
Copy link

zalito12 commented Jan 20, 2017

I don't know if this is intended or not, but when I create a new token like documentation says:

String token = JWT.create()
    .withIssuer("auth0")
    .sign(Algorithm.HMAC256("secret"));

There is no type field on header, I haven't tried other algorithms but I think it should be the same.
In the example of jwt.io there is a 'typ' field on headers.
Some places say you should check type to prevent tokens that you don't expect, I know this doesn't improve security, it's just a filter to discard malicious tokens. Anyway I'm curious about type tag.

@lbalmaceda
Copy link
Contributor

Thanks, we've added the token type claim when the token is signed.
PR: #138

@lbalmaceda lbalmaceda added this to the v3-Next milestone Apr 26, 2017
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.2.0 May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants