Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid date format" bug #258

Closed
6 tasks done
Nirajn2311 opened this issue May 16, 2023 · 2 comments · Fixed by #238
Closed
6 tasks done

"Invalid date format" bug #258

Nirajn2311 opened this issue May 16, 2023 · 2 comments · Fixed by #238
Labels
bug This points to a verified bug in the code

Comments

@Nirajn2311
Copy link

Nirajn2311 commented May 16, 2023

Checklist

  • The issue can be reproduced in the auth0_flutter sample app (or N/A).
  • I have looked into the README and have not found a suitable solution or answer.
  • I have looked into the API documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Description

If a user with a system language other than English tries using social login method(I've tested it with Google only), they are not logged in as the expiresAt value cannot be parsed due to it being in the system language. For example, if your mobile is set to use Arabic then the package tries parsing an arabic value. The ideal solution would be to parse the datetime while keeping in mind of a different locale being used by the system.

Reproduction

  1. Clone the example app
  2. Change your phones language
  3. Use a social login method through the web
  4. See the error logged in console along with the datetime

auth0_flutter version

1.1.0

Flutter version

3.7.12

Platform

Android, iOS

Platform version(s)

Latest

@stevehobbsdev
Copy link
Contributor

Thanks for raising. Seeing as you mention an example with Arabic, we have #238 that may fix this. Does the solution proposed in that PR look like it would solve your issue?

@Nirajn2311
Copy link
Author

Yes that PR fixes this issue. Hope it gets merged soon.

@stevehobbsdev stevehobbsdev added the bug This points to a verified bug in the code label May 25, 2023
@stevehobbsdev stevehobbsdev linked a pull request May 25, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants