Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline version of fuzzy-finder? #302

Closed
kbd opened this issue Jan 3, 2021 · 4 comments · Fixed by #331
Closed

Inline version of fuzzy-finder? #302

kbd opened this issue Jan 3, 2021 · 4 comments · Fixed by #331
Labels
enhancement New feature or request
Milestone

Comments

@kbd
Copy link

kbd commented Jan 3, 2021

With fzf I use the --height option to make it not go "fullscreen". With tab, if I type tab or ctrl-t, then decide not to go into one of the sessions and hit escape, it annoyingly still clears my current session.


Also, fwiw, I tried to see what would happen if I piped the name of a tab into tab so I could actually use it with fzf easily:

$ echo one | tab
thread 'tokio-runtime-worker' panicked at 'failed to enable raw mode: IoError(Os { code: 25, kind: Other, message: "Inappropriate ioctl for device" })', /Users/kbd/.cargo/registry/src/github.jparrowsec.cn-1ecc6299db9ec823/tab-command-0.5.4/src/service/terminal.rs:32:48
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@austinjones austinjones added the enhancement New feature or request label Jan 4, 2021
@austinjones
Copy link
Owner

I think there a few things I could do here:

  • I think I could make tab; ESC preserve your command history. It wouldn't work if you had disconnected from a session though - as tab resets the terminal state when disconnecting (removing the stdout from your root shell from the buffer).
  • It definitely makes sense to have echo foo | tab do something. Maybe open the fuzzy finder with the input as a query.

@kbd
Copy link
Author

kbd commented Jan 4, 2021

Just so I'm clear, here's a quick screencast of what I'm talking about with the first point. This is just opening tab up and hitting escape:

t-rec

@austinjones
Copy link
Owner

Yeah, that's expected behavior at the moment. I think I can make it better w/ the alternate buffer though.

@austinjones austinjones added this to the 0.6.0 milestone Jan 21, 2021
@austinjones
Copy link
Owner

Ah, the inappropriate ioctl error is an upstream issue in crossterm: crossterm-rs/crossterm#396

I was able to fix the 'clearing' issue though. It'll be going out with v0.6.0.

@austinjones austinjones linked a pull request Jan 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants