-
-
Notifications
You must be signed in to change notification settings - Fork 512
Consider setting Typescript compile target to ES6 #427
Comments
I'm wondering what kind of problems You have had with class inheritance? I've used superclass for views and custom elements and haven't had any problems with typescript + ES5 so far. Maybe my usecase has been different. |
Object.hasOwnProperty and Object.getPrototypeOf don't work in the es5 version. aurelia uses both. only comes into place when working on metadata of chiild classes |
Are you getting TypeScript errors and/or errors in the browser? |
's not about typings. it's how they (purposefully) implemented class inheritance for es5 |
I think there was some issues addressed in the aurelia-polyfills module. I remember running into some issues with IE11 a few weeks ago but they were fixed in the latest version of the polyfill |
hm yeah, see, fixing aurelia-polyfills is exactly what i want to avoid with this suggestion here (see aurelia/polyfills#24) |
Looks like this webpack2 branch addresses the issue |
I think we want to keep the configuration as is for now. |
Given the non-compliance of Typescript to es5 compilation (particularly class inheritance), it might be better to set the compile target of Typescript to ES6 as more features are already standard in ES6. Babel could then be used to further transpile down to ES5.
The text was updated successfully, but these errors were encountered: