fix(parser): throw on unterminated template literal

aurelia · Nov 22, 2018 · 5c5b5e3 · 5c5b5e3
1 parent ef11389
commit 5c5b5e3
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/src/parser.js b/src/parser.js
@@ -509,6 +509,8 @@ export class ParserImplementation {
         }
       } else if (this.ch === /*\*/0x5C) {
         result += fromCharCode(unescape(this.next()));
+      } else if (this.ch === /*EOF*/0 || this.idx >= this.len) {
+        this.err('Unterminated template literal');
       } else {
         result += fromCharCode(this.ch);
       }

diff --git a/test/parser.spec.js b/test/parser.spec.js
@@ -678,6 +678,35 @@ describe('Parser', () => {
       }
     });
 
+    describe('Unterminated template literal', () => {
+      const unterminatedBacktick = [
+        '`a',
+        '`',
+        'a`',
+        '`a ${b} ${`',
+        '`a ${`',
+        '`${`'
+      ];
+
+      for (const expr of unterminatedBacktick) {
+        it(expr, () => {
+          _verifyError(expr, 'Unterminated template literal');
+        });
+      }
+
+      const unterminatedExpr = [
+        '`a ${b} ${',
+        '`a ${',
+        '`${'
+      ];
+
+      for (const expr of unterminatedExpr) {
+        it(expr, () => {
+          _verifyError(expr, 'Unexpected end of expression');
+        });
+      }
+    });
+
     describe('LiteralObject with computed property', () => {
       const expressions = [
         '{ []: "foo" }',