Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of proxies kwarg in httpx==0.28.0 #555

Closed
Sergeydmitr opened this issue Dec 5, 2024 · 4 comments
Closed

Use of proxies kwarg in httpx==0.28.0 #555

Sergeydmitr opened this issue Dec 5, 2024 · 4 comments

Comments

@Sergeydmitr
Copy link
Contributor

Describe the bug
Cannot start bot after httpx update. httpx version 0.28.0 removes the deprecated proxies argument; this argument is hardcoded in the mattermostautodriver versions lower than 2.2.1.

How To Reproduce
Update to httpx version 0.28.0

Code snippets

File "/Users/foo/Library/Caches/pypoetry/virtualenvs/foo-py3.11/lib/python3.11/site-packages/mmpy_bot/bot.py", line 44, in __init__
    self.driver = Driver(
                  ^^^^^^^
  File "/Users/foo/Library/Caches/pypoetry/virtualenvs/foo-py3.11/lib/python3.11/site-packages/mmpy_bot/driver.py", line 25, in __init__
    super().__init__(*args, **kwargs)
  File "/Users/foo/Library/Caches/pypoetry/virtualenvs/foo-py3.11/lib/python3.11/site-packages/mattermostautodriver/driver.py", line 119, in __init__
    super().__init__(options, client_cls)
  File "/Users/foo/Library/Caches/pypoetry/virtualenvs/foo-py3.11/lib/python3.11/site-packages/mattermostautodriver/driver.py", line 109, in __init__
    self.client = client_cls(self.options)
                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/foo/Library/Caches/pypoetry/virtualenvs/foo-py3.11/lib/python3.11/site-packages/mattermostautodriver/client.py", line 192, in __init__
    self.client = httpx.Client(
                  ^^^^^^^^^^^^^
TypeError: Client.__init__() got an unexpected keyword argument 'proxies'

Operating Environment (please complete the following information):

  • mmpy_bot Version: 2.2.0
  • mattermostdriver/mattermostautodriver Version: 1.3.0
  • Python Version: 3.11.9
  • OS: MacOS
@Sergeydmitr
Copy link
Contributor Author

@nburlett
Copy link

Can we get a 2.2.1 release in pypi that addresses this?

@attzonko
Copy link
Owner

Done

@unode
Copy link
Collaborator

unode commented Jan 20, 2025

@attzonko Addressed also in python-mattermost-autodriver - 2.3.0 as the problem stems from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants