Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

"Ignored names" from global settings are not handled correctly #806

Open
mik01aj opened this issue Nov 2, 2016 · 5 comments
Open

"Ignored names" from global settings are not handled correctly #806

mik01aj opened this issue Nov 2, 2016 · 5 comments
Labels

Comments

@mik01aj
Copy link

mik01aj commented Nov 2, 2016

My company uses a proprietary build system adslkfsdjk. It produces lots of files in directories named adslkfsdjk-genfiles, adslkfsdjk-out, adslkfsdjk-testlogs, etc. I added adslkfsdjk-* as ignored in Atom settings, and they disappeared from tree view. Good!

But when I search for something using find-and-replace, it seems to search all the files (including these), because it hangs forever showing an empty result list with this:

image

...and my project has only around 2000 files. 😮

Note that when I put a list of these folder names explicitly in "Ignored names", the search starts working (and it's reasonably fast). Seems like a bug to me. 🐛

@mik01aj
Copy link
Author

mik01aj commented Nov 2, 2016

One more: When I specify a file/directory pattern like **/detail/* in find-and-replace, it starts searching these ignored folders again. 😕

@joseramonc
Copy link

Agree, it's happening to me too, It would be nice to have an option to ignore files in global search like fuzzy-finder does.

screen shot 2016-12-09 at 11 50 41 am

@chrishandorf
Copy link

Me too. I don't want to search the node_modules subfolder when searching within my project.

@dpehrson
Copy link

Also hitting this. I'm confused why find-and-replace searches VCS ignored folders even though that config specifically says it won't?

@dwelle
Copy link
Contributor

dwelle commented Apr 3, 2017

The Ignored names setting doesn't say it will be respected by find-and-replace package.

WTBS, it'd be nice to have a per-project settings of ignored paths for find-and-replace, possibly specified in a special file at the root of the project (I specifically don't want to put the paths into .gitignore).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants