Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to projects and profiles should open in the same tab #747

Open
noah-schechter opened this issue Oct 20, 2023 · 1 comment
Open

Links to projects and profiles should open in the same tab #747

noah-schechter opened this issue Oct 20, 2023 · 1 comment

Comments

@noah-schechter
Copy link
Collaborator

We have a slight inconsistency in the way we handle links on the Notifications page. Links to incidents open in the same tab while links to projects (for example that might arise from a "You have been added to the project []" notification) open in new tabs. Ideally, both types of links should open in the same tab. I imagine this has to do with our handling of external links—let me know if this change would cause other inconsistencies.

@noah-schechter
Copy link
Collaborator Author

This also applies to links to user profiles in comments, ie "@noah updated X", displayed in feeds (on the homepage or profile page).

@noah-schechter noah-schechter changed the title Links to projects on the Notifications page should open in the same tab Links to projects and profiles should open in the same tab Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant