Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create actions for formatting, linting, and tests #6

Open
atcupps opened this issue Dec 22, 2023 · 3 comments
Open

Create actions for formatting, linting, and tests #6

atcupps opened this issue Dec 22, 2023 · 3 comments
Assignees
@atcupps
Labels
C - datagen Component: `datagen` C - site Component: `site` good first issue Good for newcomers project Project structure, GitHub actions or jobs, etc.
Milestone
5: Backlog

Comments

@atcupps
Copy link
Owner

atcupps commented Dec 22, 2023

The only job currently run on this project is checking that the project satisfies cargo clippy. Other actions should be created and used to check for both Rust and Svelte/TS formatting, linting, and tests.
@atcupps atcupps added good first issue Good for newcomers C - datagen Component: `datagen` C - site Component: `site` project Project structure, GitHub actions or jobs, etc. labels Dec 22, 2023
@atcupps atcupps added this to the Release low priority milestone Dec 25, 2023
@atcupps atcupps mentioned this issue Dec 26, 2023
Merged
@atcupps atcupps self-assigned this Dec 26, 2023
@atcupps
Copy link
Owner Author

atcupps commented Dec 26, 2023

#22 partially resolves this, though it does not add any workflows for testing or formatting the site component. We still need to determine how testing and formatting the Svelte/TS/JS parts of Jupiterp will work. So far, testing has just been done manually in browser using Chrome dev tools and a lot of console.log, and formatting rules for site don't really exist right now.

@atcupps
Copy link
Owner Author

atcupps commented Dec 26, 2023

Just spend about an hour trying to get prettier to work with eslint, and was not able to. May have to resort to manual checking for style in .svelte and .ts files

@atcupps
Copy link
Owner Author

atcupps commented Jan 12, 2024

Once #41 is merged, should create a new action to run that as well

@atcupps atcupps modified the milestones: 2. Release low priority, 5. Backlog Mar 20, 2024
@atcupps atcupps removed this from the 5. Backlog milestone May 8, 2024
@atcupps atcupps added this to the 5: Backlog milestone May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atcupps atcupps

Labels
C - datagen Component: `datagen` C - site Component: `site` good first issue Good for newcomers project Project structure, GitHub actions or jobs, etc.
Projects
None yet
Milestone
5: Backlog
Development

No branches or pull requests
1 participant
@atcupps