Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing release scripts #104

Merged
merged 3 commits into from
Jun 29, 2022
Merged

fix: add missing release scripts #104

merged 3 commits into from
Jun 29, 2022

Conversation

derberg
Copy link
Member

@derberg derberg commented Jun 28, 2022

@ivangsa this is why release to marketplace did not work as it depends on a bump in package.json, that was missing a script

do you see any problem with us resetting versions of the plugin?

@ivangsa
Copy link
Collaborator

ivangsa commented Jun 28, 2022

I think you are able reset the version numbering because it's a new and unique publisher-artifact-version but when we'll request the extension transfer in the marketplace, we (as in "the asyncapi publisher") are going to inherit a few version numbers that I think are going to clash with this new version numbering..

not sure how that is going to work..

@derberg
Copy link
Member Author

derberg commented Jun 28, 2022

@ivangsa ok, so to be in a safe position. I reverted to 0.3.3, and will add manually GitHub Release for 0.3.3 too. So this PR will release 0.3.4. Tbh I do not mind if we start with 0.1 or continue with 0.3, both make sense 🤷🏼

objections?

@derberg derberg merged commit d2fa084 into asyncapi:master Jun 29, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member Author

derberg commented Jun 29, 2022

omg, I forgot to first create a GitHub Release.....lemme fix that...

@derberg derberg deleted the fixauto branch June 29, 2022 11:07
@derberg
Copy link
Member Author

derberg commented Jun 29, 2022

@ivangsa hey, can you have a look at failing release https://github.com/asyncapi/vs-asyncapi-preview/runs/7110671016?check_suite_focus=true Was there a webpack config before refactor to react? I can't figure why it is failing

@ivangsa
Copy link
Collaborator

ivangsa commented Jun 29, 2022

I will investigate further but npm run vscode:prepublish fails localy with the same error

@ivangsa
Copy link
Collaborator

ivangsa commented Jun 30, 2022

@derberg It seems like some transitive depdencency was missing or with a wrong version...
this was the error/warning that gave me the hint

npm WARN [email protected] requires a peer of ajv@^8.8.2 but none is installed. You must install peer dependencies yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants