-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing release scripts #104
Conversation
I think you are able reset the version numbering because it's a new and unique publisher-artifact-version but when we'll request the extension transfer in the marketplace, we (as in "the asyncapi publisher") are going to inherit a few version numbers that I think are going to clash with this new version numbering.. not sure how that is going to work.. |
@ivangsa ok, so to be in a safe position. I reverted to 0.3.3, and will add manually GitHub Release for 0.3.3 too. So this PR will release 0.3.4. Tbh I do not mind if we start with 0.1 or continue with 0.3, both make sense 🤷🏼 objections? |
🎉 This PR is included in version 0.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
omg, I forgot to first create a GitHub Release.....lemme fix that... |
@ivangsa hey, can you have a look at failing release https://github.com/asyncapi/vs-asyncapi-preview/runs/7110671016?check_suite_focus=true Was there a webpack config before refactor to react? I can't figure why it is failing |
I will investigate further but |
@derberg It seems like some transitive depdencency was missing or with a wrong version...
|
@ivangsa this is why release to marketplace did not work as it depends on a bump in package.json, that was missing a script
do you see any problem with us resetting versions of the plugin?