-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update generated docs #413
Conversation
@derberg I don't think so that this PR should be annotated as |
should be or should not? it is |
@magicmatatjahu this is a typical PR, so not sure why now you are surprised with it 😄 update bundle is normally released in the release workflow, but release workflow doesn't handle updates of the things in the repo, there is always a separate workflow that if it figures there is a need to update API docs, or bundle, or TOC in readme, then such PR is generated 😄 Mondays huh? 😆 I'm more surprised why all suddenly tests do not pass on windows because of offsets, and all was fine when things were released |
Yeah, Monday 😅 but it should be updated with version bumping in package.json like here 511d39c Also with this windows is very strange. I remember that we have problem in one PR, but I fixed it (1.11.0 probably) and then release two versions 1.11.1 and 1.12.0 and everything was ok... Maybe system update on CI or change default options for system? 🤔 |
Not necessarily, sometimes updates are caused by not-release-triggering things -> https://github.com/asyncapi/parser-js/blob/master/.github/workflows/update-docs-on-docs-commits.yml#L26 I think #411 triggered the workflow. But why bundle was outdated, this is puzzling especially that bundle was updated a merge before, with https://github.com/asyncapi/parser-js/pull/410/files
yeah, I don't know what was it before in releases that you mentioned 🤷🏼 will you investigate? |
Previously everything was fine, but the contributor was using windows, and because of that windows worked in his tests, but unix tests didn't work, so I helped him and fixed it, and everything worked until now. I will try to see what is wrong. Thanks for the explanation, it's the first time I've seen such a PR (only with updating assets) and I didn't know we had such a workflow, thanks! |
@magicmatatjahu will you push this code to this PR or separate and we are closing this one? |
Kudos, SonarCloud Quality Gate passed!
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Update of docs that are generated and were forgotten on PR level.