Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update generated docs #413

Merged
merged 4 commits into from
Nov 29, 2021
Merged

chore: update generated docs #413

merged 4 commits into from
Nov 29, 2021

Conversation

asyncapi-bot
Copy link
Contributor

Update of docs that are generated and were forgotten on PR level.

github-actions[bot]
github-actions bot previously approved these changes Nov 29, 2021
@magicmatatjahu
Copy link
Member

magicmatatjahu commented Nov 29, 2021

@derberg I don't think so that this PR should be annotated as chore, because there we have a updated browser-dist, so it should be released at least with fix. Strange that we need such a PR.

@derberg
Copy link
Member

derberg commented Nov 29, 2021

should be or should not? it is chore atm

@derberg
Copy link
Member

derberg commented Nov 29, 2021

@magicmatatjahu this is a typical PR, so not sure why now you are surprised with it 😄 update bundle is normally released in the release workflow, but release workflow doesn't handle updates of the things in the repo, there is always a separate workflow that if it figures there is a need to update API docs, or bundle, or TOC in readme, then such PR is generated 😄

Mondays huh? 😆

I'm more surprised why all suddenly tests do not pass on windows because of offsets, and all was fine when things were released

@magicmatatjahu
Copy link
Member

Yeah, Monday 😅 but it should be updated with version bumping in package.json like here 511d39c

Also with this windows is very strange. I remember that we have problem in one PR, but I fixed it (1.11.0 probably) and then release two versions 1.11.1 and 1.12.0 and everything was ok... Maybe system update on CI or change default options for system? 🤔

@derberg
Copy link
Member

derberg commented Nov 29, 2021

@magicmatatjahu

but it should be updated with version bumping in package.json like here 511d39c

Not necessarily, sometimes updates are caused by not-release-triggering things -> https://github.com/asyncapi/parser-js/blob/master/.github/workflows/update-docs-on-docs-commits.yml#L26

I think #411 triggered the workflow. But why bundle was outdated, this is puzzling especially that bundle was updated a merge before, with https://github.com/asyncapi/parser-js/pull/410/files

Also with this windows is very strange. I remember that we have a problem with one PR, but I fixed it (1.11.0 probably) and then release two versions 1.11.1 and 1.12.0 and everything was ok... Maybe system update on CI or change default options for system? 🤔

yeah, I don't know what was it before in releases that you mentioned 🤷🏼 will you investigate?

@magicmatatjahu
Copy link
Member

yeah, I don't know what was it before in releases that you mentioned 🤷🏼 will you investigate?

Previously everything was fine, but the contributor was using windows, and because of that windows worked in his tests, but unix tests didn't work, so I helped him and fixed it, and everything worked until now. I will try to see what is wrong.

Thanks for the explanation, it's the first time I've seen such a PR (only with updating assets) and I didn't know we had such a workflow, thanks!

@magicmatatjahu
Copy link
Member

@derberg Bug will be fixed in 086d653 I guess that there is windows problem/update 🤷🏼

@derberg
Copy link
Member

derberg commented Nov 29, 2021

@magicmatatjahu will you push this code to this PR or separate and we are closing this one?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu magicmatatjahu merged commit bd1423e into master Nov 29, 2021
@magicmatatjahu magicmatatjahu deleted the gen-docs-update branch November 29, 2021 17:16
@asyncapi-bot
Copy link
Contributor Author

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants