Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: un/marshal TS class functions did not render references correctly #337

Merged
merged 7 commits into from
Sep 2, 2021
Merged

fix: un/marshal TS class functions did not render references correctly #337

merged 7 commits into from
Sep 2, 2021

Conversation

jonaslagoni
Copy link
Member

Description
This PR fixes a couple of things:

  1. When enums are referenced, they should be un/marshaled as is, and not through helper functions
  2. Ensured that pattern properties and additional properties render the correct un/marshal functionality based on type.

@coveralls
Copy link

coveralls commented Sep 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1193518382

  • 36 of 36 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 93.478%
Totals Coverage Status
Change from base Build 1193234119: 0.1%
Covered Lines: 1769
Relevant Lines: 1805
💛 - Coveralls

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@jonaslagoni
Copy link
Member Author

Thanks, @magicmatatjahu!

@jonaslagoni jonaslagoni merged commit 0885834 into asyncapi:master Sep 2, 2021
@jonaslagoni jonaslagoni deleted the feature/fix_reference_marshalling branch September 2, 2021 09:12
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.27.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonaslagoni @coveralls @asyncapi-bot @magicmatatjahu