Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: render of pattern properties for JS class #302

Merged
merged 4 commits into from
Jul 9, 2021
Merged

feat: render of pattern properties for JS class #302

merged 4 commits into from
Jul 9, 2021

Conversation

jonaslagoni
Copy link
Member

Description
This PR ensures pattern properties are rendered as well as additionalProperties have accessors.

Related issue(s)
fixes #154

@jonaslagoni jonaslagoni changed the title feat: render of pattern properties feat: render of pattern properties for JS class Jul 7, 2021
@coveralls
Copy link

coveralls commented Jul 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1015589510

  • 11 of 20 (55.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 93.232%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generators/javascript/JavaScriptRenderer.ts 1 5 20.0%
src/generators/javascript/renderers/ClassRenderer.ts 10 15 66.67%
Totals Coverage Status
Change from base Build 1015089114: -0.3%
Covered Lines: 1482
Relevant Lines: 1520
💛 - Coveralls

@jonaslagoni jonaslagoni closed this Jul 8, 2021
@jonaslagoni jonaslagoni reopened this Jul 8, 2021
@jonaslagoni jonaslagoni marked this pull request as ready for review July 8, 2021 13:51
magicmatatjahu
magicmatatjahu requested changes Jul 9, 2021
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add tests for patternProperties :)

@jonaslagoni
Copy link
Member Author

Please also add tests for patternProperties :)

Doh! Adding 😄

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

magicmatatjahu
magicmatatjahu approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonaslagoni jonaslagoni merged commit 5c18205 into asyncapi:master Jul 9, 2021
@jonaslagoni jonaslagoni deleted the feature/js_pattern_properties branch July 9, 2021 15:36
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render pattern properties
4 participants
@jonaslagoni @coveralls @asyncapi-bot @magicmatatjahu