feat: render patternProperties for TS class and interface #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 974006892
💛 - Coveralls |
magicmatatjahu
requested changes
Jun 24, 2021
magicmatatjahu
requested changes
Jun 25, 2021
There was a problem hiding this comment.
One thing, but overall LGTM. We must remember about proper serialization for pattern properties and additional properties in #262 issue. At the moment we save mentioned keywords to collection but in JSON everything is flattened.
Yep, that's right. Gonna add it to the description once this is merged. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renders a pattern properties property for both class and interface presets.
Related issue(s)
Partly solves #154