Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if we can remove 'pragma: no cover' tag for missing code coverage on imports #1283

Closed
pankajkoti opened this issue Nov 22, 2022 · 2 comments
Closed

Check if we can remove 'pragma: no cover' tag for missing code coverage on imports #1283

pankajkoti opened this issue Nov 22, 2022 · 2 comments
Labels
product/sql-cli

Comments

@pankajkoti
Copy link
Contributor

In our code base, for a few imports which are added when TYPE_CHECKING is set to true, we're adding the tag
'pragma: no cover' as those lines are not covered by tests. Investigate if we can cover those lines.
@pankajkoti pankajkoti mentioned this issue Nov 22, 2022
Merged
2 tasks
@feluelle
Copy link
Member

I really don't think we can as per #1258 (comment)

@feluelle
Copy link
Member

cc @tatiana

@tatiana tatiana closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
product/sql-cli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tatiana @pankajkoti @feluelle