Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change style to PEP8 #8

Open
MatthijsMars opened this issue Dec 3, 2021 · 1 comment
Open

Change style to PEP8 #8

MatthijsMars opened this issue Dec 3, 2021 · 1 comment

Comments

@MatthijsMars
Copy link

Currently the code is not written according to standard python conventions. (e.g. all classes are in lowercase, yet should be in CapWords) . However, this will probably break a lot of existing applications since the naming of basically all the classes will change, so maybe think about this (or add some aliases and a depreciation warning.

@Luke-Pratley
Copy link

@MatthijsMars I am happy to update some of the applications that use this code, it is not a huge problem. I think it is only a few at this point. The python version of s2inv would need to be updated most likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants