Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: threshold set as constructor #87

Closed
JordyRo1 opened this issue Jul 18, 2024 · 0 comments · Fixed by #86
Closed

Audit: threshold set as constructor #87

JordyRo1 opened this issue Jul 18, 2024 · 0 comments · Fixed by #86
Assignees

Comments

@JordyRo1
Copy link
Contributor

Actual definition

  • In the actual definition, we defined a set_threshold function, callable only by the admin to define the threshold. However, since we made immutable the modules(aggregation.cairo) and validators(multisig contracts), we can define the threshold as immutable too

## Solution

  • Set the threshold in the constructor and remove set_threshold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant