Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--ignore-noqa isn't respected when RUF100 is enabled #3468

Closed
charliermarsh opened this issue Mar 12, 2023 · 2 comments · Fixed by #3469
Closed

--ignore-noqa isn't respected when RUF100 is enabled #3468

charliermarsh opened this issue Mar 12, 2023 · 2 comments · Fixed by #3469
Labels
bug Something isn't working

Comments

@charliermarsh
Copy link
Member

If RUF100 is enabled, we end up running the noqa checker even if the noqa flag is not enabled. As a result, --ignore-noqa has no effect when RUF100 is selected.
@charliermarsh charliermarsh added the bug Something isn't working label Mar 12, 2023
@charliermarsh charliermarsh mentioned this issue Mar 12, 2023
Merged
@onerandomusername
Copy link

This is still an issue with 0.0.256, though not necessarily when RUF100 is enabled.

@onerandomusername
Copy link

Ignore me, I just realised I didn't have my virtual environment enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid respecting noqa directives when RUF100 is enabled astral-sh/ruff
2 participants
@charliermarsh @onerandomusername