Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CI_PROJECT_DIR-relative paths for GitLab annotations #3443

Closed
charliermarsh opened this issue Mar 10, 2023 · 2 comments · Fixed by #3475
Closed

Use CI_PROJECT_DIR-relative paths for GitLab annotations #3443

charliermarsh opened this issue Mar 10, 2023 · 2 comments · Fixed by #3475
Labels
bug Something isn't working

Comments

@charliermarsh
Copy link
Member

At least for Gitlab path should be relative to the CI_PROJECT_DIR location. With this implementation links in widgets are broken.

Originally posted by @Agalin in #1837 (comment)

@charliermarsh charliermarsh added the bug Something isn't working label Mar 10, 2023
@Agalin
Copy link

Agalin commented Mar 10, 2023

I'd say there are two options:

  • Make it relative to the mentioned variable if present - but what happens if it's not defined?
  • Keep paths just relative. I'm not familiar with Github's directory changing but I see no reason why toll cannot be called from a parent directory. It's already possible to use a config from subdirectory and select only subdir files for scan.

@charliermarsh
Copy link
Member Author

I guess my initial reaction is that we should try to make relative to CI_PROJECT_DIR, then fallback to cwd-relative if it's not defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants