Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UP036 doesn't handle three digit version numbers correctly #16082

Closed
henryiii opened this issue Feb 10, 2025 · 0 comments · Fixed by #16091
Closed

UP036 doesn't handle three digit version numbers correctly #16082

henryiii opened this issue Feb 10, 2025 · 0 comments · Fixed by #16091
Labels
bug Something isn't working rule Implementing or modifying a lint rule

Comments

@henryiii
Copy link
Contributor

Description

The following check:

if sys.version_info < (3, 8, 7):

Should not be removed for Python >=3.8, but currently, it is - the check seems to ignore the third digit entirely. It should only be removed for >=3.9. Occurs in Python packaging related repos like scikit-build-core due to a bug in sysconfig fixed in 3.8.7.
@AlexWaygood AlexWaygood added bug Something isn't working rule Implementing or modifying a lint rule labels Feb 10, 2025
@InSyncWithFoo InSyncWithFoo mentioned this issue Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pyupgrade] Handle micro version numbers correctly (UP036) InSyncWithFoo/ruff
2 participants
@henryiii @AlexWaygood