From ba6c7f6897df6d8020c6b393d1d2f51963fee2b2 Mon Sep 17 00:00:00 2001 From: Dylan <53534755+dylwil3@users.noreply.github.com> Date: Thu, 14 Nov 2024 16:26:50 -0600 Subject: [PATCH] [`pylint`] Remove check for dot in alias name in `useless-import-alias (PLC0414)` (#14345) Follow-up to #14287 : when checking that `name` is the same as `as_name` in `import name as as_name`, we do not need to first do an early return if `'.'` is found in `name`. --- .../src/rules/pylint/rules/useless_import_alias.rs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/crates/ruff_linter/src/rules/pylint/rules/useless_import_alias.rs b/crates/ruff_linter/src/rules/pylint/rules/useless_import_alias.rs index 0230ca802739b2..6934c39f917871 100644 --- a/crates/ruff_linter/src/rules/pylint/rules/useless_import_alias.rs +++ b/crates/ruff_linter/src/rules/pylint/rules/useless_import_alias.rs @@ -59,9 +59,6 @@ pub(crate) fn useless_import_alias(checker: &mut Checker, alias: &Alias) { let Some(asname) = &alias.asname else { return; }; - if alias.name.contains('.') { - return; - } if alias.name.as_str() != asname.as_str() { return; } @@ -97,9 +94,6 @@ pub(crate) fn useless_import_from_alias( let Some(asname) = &alias.asname else { return; }; - if alias.name.contains('.') { - return; - } if alias.name.as_str() != asname.as_str() { return; }