-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from julius to torchaudio? #419
Comments
Yes, what's your take on that? |
I think it’s not worth it dropping 1.6 support just for this one fewer dependency. |
I'd agree with that. |
Let's discuss it again in 2023 :-D |
Let's see the future releases of PyTorch. Maybe we'll switch to new ones only because of complex support? I'll keep in mind but I'll close now. |
@mpariente torchaudio 0.9 release supports native complex types now! (https://github.com/pytorch/audio/releases) |
Thanks @anjali411 👍 |
julius' resample implementation has been merged into torchaudio: pytorch/audio#1057
Shall we switch to that as soon as the new torchaudio is released? (Would probably mean that we don't support earlier versions of PyTorch anymore though, because of torchaudio->PyTorch dependency?)
The text was updated successfully, but these errors were encountered: