Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from julius to torchaudio? #419

Closed
jonashaag opened this issue Jan 26, 2021 · 7 comments
Closed

Switch from julius to torchaudio? #419

jonashaag opened this issue Jan 26, 2021 · 7 comments

Comments

@jonashaag
Copy link
Collaborator

julius' resample implementation has been merged into torchaudio: pytorch/audio#1057

Shall we switch to that as soon as the new torchaudio is released? (Would probably mean that we don't support earlier versions of PyTorch anymore though, because of torchaudio->PyTorch dependency?)

@mpariente
Copy link
Collaborator

Would probably mean that we don't support earlier versions of PyTorch anymore though, because of torchaudio->PyTorch dependency?

Yes, what's your take on that?

@jonashaag
Copy link
Collaborator Author

I think it’s not worth it dropping 1.6 support just for this one fewer dependency.

@mpariente
Copy link
Collaborator

I'd agree with that.
But when will we move then? 😄

@jonashaag
Copy link
Collaborator Author

Let's discuss it again in 2023 :-D

@mpariente
Copy link
Collaborator

Let's see the future releases of PyTorch. Maybe we'll switch to new ones only because of complex support?

I'll keep in mind but I'll close now.

@anjali411
Copy link

@mpariente torchaudio 0.9 release supports native complex types now! (https://github.com/pytorch/audio/releases)

@mpariente
Copy link
Collaborator

Thanks @anjali411 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants