Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proxy]: Room counter UX not intuitive #8836 #143

Closed
mrsimpson opened this issue Nov 10, 2017 · 3 comments
Closed

[Proxy]: Room counter UX not intuitive #8836 #143

mrsimpson opened this issue Nov 10, 2017 · 3 comments
Assignees
@mrsimpson
Labels
Cmp: Rocket.Chat Core Priority: Medium Type: Improvement

Comments

@mrsimpson
Copy link
Member

see RocketChat#8836
@mrsimpson mrsimpson self-assigned this Nov 10, 2017
@mrsimpson
Copy link
Member Author

mrsimpson commented Nov 10, 2017 •
edited
Loading

packages/rocketchat-ui-sidenav/client/roomList.html -> count

@mrsimpson
Copy link
Member Author

seems not to be that easy to understand, where the count is coming from. Shortterm-workaround: hide it via custom css:

.rooms-list__type .badge{
  	display: none
}

@mrsimpson
Copy link
Member Author

understood where it comes from: rooms() returns a cursor based on ChatSubscription . count invokes count() on the cursor => the chat subscription would need to be filtered

@ghost ghost removed the progress:working label Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrsimpson mrsimpson

Labels
Cmp: Rocket.Chat Core Priority: Medium Type: Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janrudolph @mrsimpson