-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prkrishn/code coverage #2308
Prkrishn/code coverage #2308
Changes from all commits
4f0e720
8c21ce3
9359876
e28c913
599a762
7470573
baac3d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"version": 1, | ||
"isRoot": true, | ||
"tools": { | ||
"coverlet.console": { | ||
"version": "1.5.51-ged9195d73b", | ||
"commands": [ | ||
"coverlet" | ||
] | ||
}, | ||
"dotnet-reportgenerator-globaltool": { | ||
"version": "4.1.6", | ||
"commands": [ | ||
"reportgenerator" | ||
] | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,20 +108,9 @@ stages: | |
arguments: 'locals all -clear' | ||
- script: eng\common\cibuild.cmd -configuration $(_BuildConfig) -prepareMachine $(_BuildArgs) | ||
displayName: Build and Publish | ||
- script: eng\scripts\ci-flaky-tests.cmd -configuration $(_BuildConfig) | ||
displayName: Run Flaky Tests | ||
continueOnError: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't look right. Why are you removing the flaky test run? |
||
- powershell: eng\scripts\KillProcesses.ps1 | ||
displayName: Kill processes | ||
condition: always() | ||
- task: PublishTestResults@2 | ||
displayName: Publish Flaky Test Results | ||
inputs: | ||
testResultsFormat: 'xUnit' | ||
testResultsFiles: '*.xml' | ||
searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky' | ||
continueOnError: true | ||
condition: always() | ||
- task: PublishBuildArtifacts@1 | ||
displayName: Upload TestResults | ||
condition: always() | ||
|
@@ -131,6 +120,15 @@ stages: | |
artifactName: $(Agent.Os)_$(Agent.JobName) TestResults | ||
artifactType: Container | ||
parallel: true | ||
- task: PublishBuildArtifacts@1 | ||
displayName: Upload Code Coverage results | ||
condition: always() | ||
continueOnError: true | ||
inputs: | ||
pathtoPublish: artifacts/log/$(_BuildConfig)/codecoverage/ | ||
artifactName: $(Agent.Os)_$(Agent.JobName) CodeCoverage | ||
artifactType: Container | ||
parallel: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aren't these files included when all of artifacts/log is uploaded? |
||
- task: PublishBuildArtifacts@1 | ||
displayName: Upload package artifacts | ||
condition: and(succeeded(), eq(variables['system.pullrequest.isfork'], false), eq(variables['_BuildConfig'], 'Release')) | ||
|
@@ -308,4 +306,4 @@ stages: | |
parameters: | ||
# Symbol validation isn't being very reliable lately. This should be enabled back | ||
# once this issue is resolved: https://github.com/dotnet/arcade/issues/2871 | ||
enableSymbolValidation: false | ||
enableSymbolValidation: false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
@echo off | ||
powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0Build.ps1""" -restore -build -test -sign -pack -publish -ci %*" | ||
powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0Build.ps1""" -restore -build -test /p:RunCodeCoverage=true -ci %*" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
} | ||
}, | ||
"msbuild-sdks": { | ||
"Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19458.2", | ||
"Microsoft.DotNet.Helix.Sdk": "2.0.0-beta.19458.2" | ||
"Microsoft.DotNet.Arcade.Sdk": "4.0.0-dev", | ||
"Microsoft.DotNet.Helix.Sdk": "2.0.0-beta.19454.31" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not change this portion of the file directly. Need to update the dependencies from Arcade i.e. get In your branch, execute darc update-dependencies --source-repo arcade --channel '.NET Tools - Latest' or darc update-dependencies --source-repo arcade --channel '.NET 3 Tools' |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will reference this new file?