Fix to #18522 - Query: SqlFunctionExpression instance should be SqlExpression rather than Expression #18894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Nov 14, 2019
| @@ -116,7 +116,7 @@ protected override Expression VisitExtension(Expression extensionExpression) | |||
| protected abstract Expression VisitSqlFragment(SqlFragmentExpression sqlFragmentExpression); | |||
| protected abstract Expression VisitSqlFunction(SqlFunctionExpression sqlFunctionExpression); | |||
| protected abstract Expression VisitSqlParameter(SqlParameterExpression sqlParameterExpression); | |||
| protected abstract Expression VisitSqlUnary(SqlUnaryExpression sqlCastExpression); | |||
| protected abstract Expression VisitSqlUnary(SqlUnaryExpression sqlUnaryExpression); | |||
| protected abstract Expression VisitSubSelect(ScalarSubqueryExpression scalarSubqueryExpression); | |||
There was a problem hiding this comment.
Break this too. VisitScalarSubquery.
smitpatel
reviewed
Nov 14, 2019
| @@ -82,7 +82,7 @@ protected override Expression VisitExtension(Expression extensionExpression) | |||
| return VisitSqlParameter(sqlParameterExpression); | |||
|
|
|||
| case ScalarSubqueryExpression subSelectExpression: | |||
smitpatel
approved these changes
Nov 15, 2019
…pression rather than Expression Resolves #18522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18522