Handle NewArrayExpression in entity equality #18296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17744
@smitpatel the fix here is trivial/minimal to unblock the issue for 3.1: the EE visitor simply ignores (unwraps) entity reference node coming up from the NewArray's expressions.
A more complete fix would be to actually bubble this information up (probably all expressions must bubble up the same thing, or we start tracking information per element, like we do for anonymous objects). However, unless I'm mistaken, there's not actually much (anything?) that can be composed over this which EF Core can actually translate. For example, we don't support subscripting the array just created or anything similar, so there doesn't seem to be any value in this (right now).
Let me know if this sounds reasonable and if you'd like me to do something more on this.