Stop using similar-looking owned entity in deeply nested case #16946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Aug 5, 2019
Fixes #15839 The issue was that both the immediate owner for `Rejection.FirstTest#FirstTest.Tester#SpecialistStaff` and `Attitude.FirstTest#FirstTest.Tester#SpecialistStaff` are the same resulting in the former being mistaken for the latter. The fix is to use the type rather than its name.
ajcvickers
force-pushed
the
ThisIsNotATpsReport0731
branch
from
0cfd84c to
1828f38
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15839
The issue was that both the immediate owner for
Rejection.FirstTest#FirstTest.Tester#SpecialistStaffandAttitude.FirstTest#FirstTest.Tester#SpecialistStaffare the same resulting in the former being mistaken for the latter. The fix is to use the type rather than its name.