-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SQLitePCL.raw to 2.0.0 #16189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+OSS approvals probably
@ericsink Looks like the SQLite tests deadlock. I'll investigate more... |
That's unfortunate. Let me know if there is a way I can help. |
@ericsink The string overload of sqlite2_prepare_v2 sets tail to |
@bricelam Ouch. Sorry about that. Well at least it'll be an easy fix. Much easier than I was expecting once the word "deadlock" appeared. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
One last failure (of 11,730 tests). I'll investigate. Could be a SQLite bug...
|
Couldn't see anything obviously wrong with the translation for that test. |
It's a SQLite bug. Results are different in 3.28.0 (repros without e_sqlite3) SELECT (
SELECT "t"."CustomerID"
FROM (
SELECT "o"."CustomerID", "o"."OrderDate"
FROM "Orders" AS "o"
WHERE ("c"."CustomerID" = "o"."CustomerID") AND "o"."CustomerID" IS NOT NULL
ORDER BY "o"."CustomerID", "o"."OrderDate" DESC
LIMIT 2
) AS "t"
ORDER BY "t"."CustomerID", "t"."OrderDate" DESC
LIMIT 1)
FROM "Customers" AS "c"; |
@bricelam A new prerelease of SQLitePCLRaw has been pushed up to nuget.org, with fixes for: ericsink/SQLitePCL.raw#274 |
Filed #16187 and #16202 to take more advantage of the new Span overloads.
Resolves #14824