Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ef-core-2.0.md #1892

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Update ef-core-2.0.md #1892

merged 2 commits into from
Nov 8, 2019

Conversation

vanillajonathan
Copy link
Contributor

No description provided.

@ajcvickers
Copy link
Contributor

@vanillajonathan Are the changes here only to add backticks on type/member names? If so, this isn't a change we are planning to make because unfortunately the reading experience for backticked words is too jarring to use everywhere.

@vanillajonathan
Copy link
Contributor Author

@ajcvickers Well the backticks should probably be present on the first mention of a property, method, class or interface. Then on subsequent mentions there is less need for it to be marked up in backticks if that is considering too jarring.

The commit does other things too, such as consistent capitalization of headers, hyphenation between words, and proper 4-space indention for code.

@ajcvickers
Copy link
Contributor

@vanillajonathan The intention is to only use backticks when we want to explicitly call attention to something being a type/member names. I don't think this is the case for most of the changes here.

Remove backticks due to feedback from @ajcvickers
@vanillajonathan
Copy link
Contributor Author

@ajcvickers I reverted the backticks that I added.

@ajcvickers
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants