This repository was archived by the owner on Oct 31, 2024. It is now read-only.
feat: new elasticsearch instrumentation #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirsky
reviewed
Mar 1, 2021
| "@opentelemetry/api": "^0.17.0", | ||
| "@opentelemetry/instrumentation": "^0.17.0", | ||
| "@opentelemetry/semantic-conventions": "^0.17.0", | ||
| "test-all-versions": "^5.0.1" |
nirsky
reviewed
Mar 1, 2021
| import { startSpan, onError, onResponse, defaultDbStatementSerializer, normalizeArguments } from './utils'; | ||
| import { ELASTICSEARCH_API_FILES } from './helpers'; | ||
|
|
||
| type Config = InstrumentationConfig & ElasticsearchInstrumentationConfig; |
There was a problem hiding this comment.
i actually changes this and used ElasticsearchInstrumentationConfig directly instead
nirsky
reviewed
Mar 1, 2021
| import { Span } from '@opentelemetry/api'; | ||
| import { InstrumentationConfig } from '@opentelemetry/instrumentation'; | ||
|
|
||
| export interface SerializerPayload { |
There was a problem hiding this comment.
unused, copied from mongoose
nirsky
reviewed
Mar 1, 2021
| aggregatePipeline?: any; | ||
| } | ||
|
|
||
| export type DbStatementSerializer = (params?: object, options?: object) => string; |
There was a problem hiding this comment.
could be nice to pass the operation as well, like in mongoose and redis
nirsky
reviewed
Mar 1, 2021
| @@ -0,0 +1,8 @@ | |||
| Copyright 2021 @ Aspecto | |||
nirsky
reviewed
Mar 1, 2021
| "watch": "tsc -w", | ||
| "version:update": "node ../../scripts/version-update.js", | ||
| "version": "yarn run version:update", | ||
| "test": "mocha" |
There was a problem hiding this comment.
shouldn't be invoked with tav?
added 9 commits
March 1, 2021 17:18
…to feat/esInstument
blumamir
reviewed
Mar 1, 2021
package.json
Outdated
| @@ -3,6 +3,7 @@ | |||
| "private": true, | |||
| "scripts": { | |||
| "test": "lerna run test", | |||
| "test:ci": "yarn test", | |||
blumamir
approved these changes
Mar 1, 2021
blumamir
reviewed
Mar 1, 2021
package.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "name": "root", | |||
| "private": true, | |||
| "scripts": { | |||
| "test": "lerna run test", | |||
| "test": "lerna run test:ci", | |||
There was a problem hiding this comment.
should be lerna run test
and add another one called "test:ci": "lerna run test:ci"
nirsky
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.