This repository was archived by the owner on Oct 31, 2024. It is now read-only.
feat: support core experimental version 0.32.0 #240
Merged
+22
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the amazing libs!
This PR updates the core experimental version to 0.32.0. I used this PR as a base for my work.
I had some problems running tests locally for the mongoose and neo4j instrumentations, it seems I need to configure those tools in my local environment.
Edit: Found the comments in the tests about how to setup Docker for those instrumentations, all tests have passed.
I also had some problems with peer dependencies like:
I ignored these errors because they happened before I even started updating deps. I am probably missing something basic as I have little knowledge of Yarn in a lerna project. I tried looking for a contributing guide but could not find it. If you have it, could you please link it here so I can follow?
I checked the release Changelogs for experimental packages on opentelemetry-js and it seems the packages here are not affected by the breaking changes. There are some deprecations to resolve but I think making a separate PR for them would be better as they require more effort and knowledge.