Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source detail page NED links are broken #621

Closed
marxide opened this issue Feb 13, 2022 · 2 comments · Fixed by #623
Closed

Source detail page NED links are broken #621

marxide opened this issue Feb 13, 2022 · 2 comments · Fixed by #623
Assignees
@marxide
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@marxide
Copy link
Contributor

marxide commented Feb 13, 2022

Reported by @radioastronomer via Slack:

When you click on the NED link, one consistently gets a lost precision error. This appears to be because a full double’s worth of precision may be betting passed. If we assume 0.01" precision (which is more than we need for matching), I think we need to have the string pass include {0:.6} .format(RA) and {0:.6} .format(Dec) or something similar.
@marxide marxide added the bug Something isn't working label Feb 13, 2022
@marxide marxide self-assigned this Feb 13, 2022
@marxide marxide added the good first issue Good for newcomers label Feb 13, 2022
@marxide
Copy link
Contributor Author

marxide commented Feb 14, 2022

Additional info from @ajfox123 via Slack:

I've found that sources with positive declination coordinate need to have a "+" in between the RA and DEC for links to NED or it won't find the object.

@marxide marxide linked a pull request Feb 14, 2022 that will close this issue
fixed NED links #623
Merged
@marxide
Copy link
Contributor Author

marxide commented Feb 14, 2022

Fixed in 45361eb.

@marxide marxide closed this as completed Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marxide marxide

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed NED links askap-vast/vast-pipeline
1 participant
@marxide