Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMBAD and NED table on source detail page returning nan names and types #519

Closed
ajstewart opened this issue May 10, 2021 · 0 comments · Fixed by #523
Closed

SIMBAD and NED table on source detail page returning nan names and types #519

ajstewart opened this issue May 10, 2021 · 0 comments · Fixed by #523
Labels
bug Something isn't working UI User Interface
Milestone

Comments

@ajstewart
Copy link
Contributor

I'm pretty sure it's a simple fix that string decoding on the results is no longer required, for example, removing the following lines solves the issue for SIMBAD. Though I'm not sure where that change has come from.

bytestring_fields = ["MAIN_ID", "OTYPE_S", "OTYPE_V"]
simbad_results_df[bytestring_fields] = simbad_results_df[
bytestring_fields
].apply(lambda col: col.str.decode("utf-8"))

Screen Shot 2021-05-05 at 09 46 00

@ajstewart ajstewart added bug Something isn't working UI User Interface labels May 10, 2021
@ajstewart ajstewart added this to the v0.3.0 milestone May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI User Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant