Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquets (and arrow files) not being removed before a run (not a bug) #418

Closed
ajstewart opened this issue Nov 18, 2020 · 0 comments · Fixed by #421
Closed

Parquets (and arrow files) not being removed before a run (not a bug) #418

ajstewart opened this issue Nov 18, 2020 · 0 comments · Fixed by #421
Assignees
Labels
enhancement New feature or request

Comments

@ajstewart
Copy link
Contributor

I think usually this was fine as the files are just overwritten, but with the arrow files being present a user might run with arrow files on, and then re-run with arrow files off. In this case the arrow files need to be removed from the job directory.

The forced parquets are removed here:

# clean up pipeline images and forced measurements for re-runs
if flag_exist:
logger.info('Cleaning up pipeline run before re-process data')
p_run.image_set.clear()
if not pipeline.config.MONITOR:
logger.info(
'Cleaning up forced measurements before re-process data'
)
forced_parquets = remove_forced_meas(p_run.path)
for parquet in forced_parquets:
os.remove(parquet)

I suggest that at this point we just remove all parquets and arrows from the job directory to be clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant