Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access websocket on port not equal 80 #6

Closed
afr4283 opened this issue Dec 24, 2022 · 2 comments
Closed

Access websocket on port not equal 80 #6

afr4283 opened this issue Dec 24, 2022 · 2 comments

Comments

@afr4283
Copy link

afr4283 commented Dec 24, 2022

You might want to use
let gateway = ``ws://${window.location.host}/webserialws``;
instead of
let gateway = ``ws://${window.location.hostname + window.location.port + window.location.pathname}/webserialws``;

That combination of hostname, port and pathname is not working at all, even on port 80, it tries to access /webserial/webserialws

@asjdf
Copy link
Owner

asjdf commented Jan 1, 2023

Thanks for the suggestion, but I don't have a test device at the moment, could you please do a PR to implement this feature?

@asjdf asjdf mentioned this issue Jan 23, 2023
@asjdf
Copy link
Owner

asjdf commented Feb 16, 2023

Thank you for your suggestion. This issue was solved in v2.1.0.

@asjdf asjdf closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants