diff --git a/arquillian-service-integration-spring/src/main/java/org/jboss/arquillian/spring/integration/client/SpringIntegrationConfigurationProducer.java b/arquillian-service-integration-spring/src/main/java/org/jboss/arquillian/spring/integration/client/SpringIntegrationConfigurationProducer.java index 13289c8..d9d539b 100644 --- a/arquillian-service-integration-spring/src/main/java/org/jboss/arquillian/spring/integration/client/SpringIntegrationConfigurationProducer.java +++ b/arquillian-service-integration-spring/src/main/java/org/jboss/arquillian/spring/integration/client/SpringIntegrationConfigurationProducer.java @@ -17,19 +17,17 @@ package org.jboss.arquillian.spring.integration.client; +import java.util.Collections; +import java.util.Map; + import org.jboss.arquillian.config.descriptor.api.ArquillianDescriptor; import org.jboss.arquillian.config.descriptor.api.ExtensionDef; -import org.jboss.arquillian.core.api.Instance; import org.jboss.arquillian.core.api.InstanceProducer; import org.jboss.arquillian.core.api.annotation.ApplicationScoped; import org.jboss.arquillian.core.api.annotation.Inject; import org.jboss.arquillian.core.api.annotation.Observes; import org.jboss.arquillian.spring.integration.SpringIntegrationConstants; import org.jboss.arquillian.spring.integration.configuration.SpringIntegrationConfiguration; -import org.jboss.arquillian.test.spi.event.suite.BeforeSuite; - -import java.util.Collections; -import java.util.Map; /** *

Producer that creates the configuration loaded from the arquillian descriptor.

@@ -39,12 +37,6 @@ */ public class SpringIntegrationConfigurationProducer { - /** - *

Represents the application descriptor.

- */ - @Inject - private Instance descriptor; - /** *

Represents the configuration for this extension.

*/ @@ -57,7 +49,7 @@ public class SpringIntegrationConfigurationProducer { * * @param beforeSuiteEvent the event fired before execution of the test suite */ - public void initConfiguration(@Observes BeforeSuite beforeSuiteEvent) { + public void initConfiguration(@Observes ArquillianDescriptor descriptor) { SpringIntegrationConfiguration config = getConfiguration(descriptor); @@ -71,9 +63,9 @@ public void initConfiguration(@Observes BeforeSuite beforeSuiteEvent) { * * @return the created instance of {@link SpringIntegrationConfiguration} */ - private SpringIntegrationConfiguration getConfiguration(Instance descriptor) { + private SpringIntegrationConfiguration getConfiguration(ArquillianDescriptor descriptor) { - Map properties = getExtensionProperties(descriptor.get()); + Map properties = getExtensionProperties(descriptor); return new SpringIntegrationConfiguration(properties); } diff --git a/arquillian-service-integration-spring/src/test/java/org/jboss/arquillian/spring/integration/client/SpringIntegrationConfigurationProducerTestCase.java b/arquillian-service-integration-spring/src/test/java/org/jboss/arquillian/spring/integration/client/SpringIntegrationConfigurationProducerTestCase.java index 080d7de..897ad5d 100644 --- a/arquillian-service-integration-spring/src/test/java/org/jboss/arquillian/spring/integration/client/SpringIntegrationConfigurationProducerTestCase.java +++ b/arquillian-service-integration-spring/src/test/java/org/jboss/arquillian/spring/integration/client/SpringIntegrationConfigurationProducerTestCase.java @@ -17,6 +17,16 @@ package org.jboss.arquillian.spring.integration.client; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import java.io.File; +import java.io.FileInputStream; + import org.jboss.arquillian.config.descriptor.api.ArquillianDescriptor; import org.jboss.arquillian.core.api.Instance; import org.jboss.arquillian.core.api.InstanceProducer; @@ -28,16 +38,6 @@ import org.junit.Test; import org.mockito.ArgumentCaptor; -import java.io.File; -import java.io.FileInputStream; - -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertNull; -import static org.mockito.Mockito.mock; -import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.when; - /** *

Tests {@link SpringIntegrationConfigurationProducer} class.

* @@ -67,16 +67,12 @@ public void setUp() { @Test public void testInitConfigurationDefault() throws Exception { - BeforeSuite event = new BeforeSuite(); - ArquillianDescriptor descriptor = Descriptors.create(ArquillianDescriptor.class); - injectDescriptor(descriptor); - InstanceProducer mockProducer = mock(InstanceProducer.class); TestReflectionHelper.setFieldValue(instance, "extensionConfiguration", mockProducer); - instance.initConfiguration(event); + instance.initConfiguration(descriptor); ArgumentCaptor argument = ArgumentCaptor.forClass(SpringIntegrationConfiguration.class); @@ -96,17 +92,13 @@ public void testInitConfigurationDefault() throws Exception { @Test public void testInitConfiguration() throws Exception { - BeforeSuite event = new BeforeSuite(); - ArquillianDescriptor descriptor = Descriptors.importAs(ArquillianDescriptor.class).fromStream( new FileInputStream(new File("src/test/resources", "arquillian.xml"))); - injectDescriptor(descriptor); - InstanceProducer mockProducer = mock(InstanceProducer.class); TestReflectionHelper.setFieldValue(instance, "extensionConfiguration", mockProducer); - instance.initConfiguration(event); + instance.initConfiguration(descriptor); ArgumentCaptor argument = ArgumentCaptor.forClass(SpringIntegrationConfiguration.class); @@ -120,18 +112,4 @@ public void testInitConfiguration() throws Exception { "org.springframework.context.annotation.AnnotationConfigApplicationContext", argument.getValue().getProperty("customAnnotationContextClass")); } - - /** - *

Initialize the arquillian descriptor.

- * - * @param descriptor the arquillian descriptor - * - * @throws IllegalAccessException if any error occurs - * @throws NoSuchFieldException if any error occurs - */ - private void injectDescriptor(ArquillianDescriptor descriptor) throws IllegalAccessException, NoSuchFieldException { - Instance mockDescriptorInstance = mock(Instance.class); - when(mockDescriptorInstance.get()).thenReturn(descriptor); - TestReflectionHelper.setFieldValue(instance, "descriptor", mockDescriptorInstance); - } }