From fff0655aa9cf2854849376dc8f77af216431e1c1 Mon Sep 17 00:00:00 2001 From: Jacek Sieka Date: Tue, 13 Aug 2024 14:49:25 +0200 Subject: [PATCH] don't test non-default lent setting it's failing all over the place --- results.nim | 10 +++++----- results.nimble | 5 +---- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/results.nim b/results.nim index bcda10a..bb94963 100644 --- a/results.nim +++ b/results.nim @@ -378,11 +378,11 @@ const resultsGenericsOpenSymWorkaroundHint* {.booldefine.} = true resultsLent {.booldefine.} = (NimMajor, NimMinor, NimPatch) >= (2, 0, 8) - ## Enable return of `lent` types - this *mostly* works in Nim 1.6+ but there - ## have been edge cases reported as late as 1.6.14 - YMMV - conservatively, - ## `lent` is therefore enabled only with the latest Nim version at the time - ## of writing, where it could be verified to work with several large - ## applications + ## Enable return of `lent` types - this *mostly* works in Nim 1.6.18+ but + ## there have been edge cases reported as late as 1.6.14 - YMMV - + ## conservatively, `lent` is therefore enabled only with the latest Nim + ## version at the time of writing, where it could be verified to work with + ## several large applications. when resultsLent: template maybeLent(T: untyped): untyped = lent T diff --git a/results.nimble b/results.nimble index eda8848..004c5d6 100644 --- a/results.nimble +++ b/results.nimble @@ -19,10 +19,7 @@ proc test(env, path: string) = task test, "Runs the test suite": for f in ["test_results.nim", "test_results2.nim"]: - for opt in [ - "-d:resultsGenericsOpenSym:false", "-d:resultsGenericsOpenSym:true", - "-d:resultsLent=false", "-d:resultsLent=true", - ]: + for opt in ["-d:resultsGenericsOpenSym:false", "-d:resultsGenericsOpenSym:true"]: test opt, "tests/" & f if (NimMajor, NimMinor) >= (2, 0): test opt & " --mm:refc", "tests/" & f